docs: update fetching user details endpoint for ecosystems #4918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
MananTank,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0f6b881 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
ElasticBottle
changed the title
github-actions
bot
added
the
Portal
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| - `walletAddress`: The user's wallet address that thirdweb has generated for them | ||
| - `email`: The user's email address | ||
| - `phone`: The user's phone number | ||
| - `extenalWalletAddress`: The user's wallet address that used to login via SIWE |
Contributor
There was a problem hiding this comment.
The parameter extenalWalletAddress contains a typo. It should be corrected to externalWalletAddress for accuracy and consistency. This change will ensure that users can properly reference this parameter when querying user details for those who have logged in via SIWE.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4918 +/- ##
==========================================
- Coverage 47.61% 47.60% -0.02%
==========================================
Files 1057 1057
Lines 57224 57228 +4
Branches 3924 3923 -1
==========================================
- Hits 27247 27241 -6
- Misses 29288 29298 +10
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Oct 4, 2024
Member
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
Wanna update the SDK function as well?
Contributor
size-limit report 📦
|
| ...(ecosystem?.id ? { "x-ecosystem-id": ecosystem.id } : {}), | ||
| ...(ecosystem?.partnerId | ||
| ? { "x-ecosystem-partner-id": ecosystem.partnerId } | ||
| : {}), |
Member
There was a problem hiding this comment.
you dont need to do this! just pass ecosystem to getClientFetch :)
actually just did it in my other PR, though i didn't add externalWalletAddress support. just merge my change and you'll get the headers for free
joaquim-verges
approved these changes
Oct 4, 2024
joaquim-verges
added
the
merge-queue
Contributor
Merge activity
|
joaquim-verges
pushed a commit
that referenced
this pull request
Oct 4, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `getUser` functionality in the `thirdweb` SDK by adding support for querying user details via an external wallet address and ecosystem wallet details.
### Detailed summary
- Added functionality to query user details using `externalWalletAddress`.
- Updated documentation for `getUser` to reflect new parameters.
- Modified examples to include querying by `externalWalletAddress`.
- Enhanced user guide to include new querying options.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
winston/update-user-details-doc-to-include-ecosystem
branch
from
156cc11 to
77d0c13
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `getUser` functionality in the `thirdweb` SDK by adding support for querying user details via an external wallet address and ecosystem identifiers.
### Detailed summary
- Added support for querying user details using `externalWalletAddress` in `getUser`.
- Updated documentation for `getUser` to include `externalWalletAddress` as a query parameter.
- Modified examples in the documentation to demonstrate querying with `externalWalletAddress`.
- Updated user detail query parameters in documentation to reflect new options.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
winston/update-user-details-doc-to-include-ecosystem
branch
from
77d0c13 to
0f6b881
Compare
graphite-app
bot
deleted the
winston/update-user-details-doc-to-include-ecosystem
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
getUserfunction from thethirdwebSDK to support querying user details by external wallet address and adding documentation updates to reflect these changes.Detailed summary
externalWalletAddress.getUserfunction parameters to includeexternalWalletAddress.externalWalletAddress.